SqlServerDsc: Stop instances in integration tests #1115
Conversation
- Changes to SqlAlwaysOnService
- Updated the integration tests to use a loopback adapter to be less intrusive
in the build worker environment.
- Minor code cleanup in integration test, fixed the scope on variable.
- Changes to SqlSetup
- Updated the integration tests to stop the services after each integration test.
This is to save memory on the AppVeyor build worker.
Updated the integration tests to use a SQL Server 2016 Service Pack 1.
- Updated the integration tests to stop the Reporting Services service after the integration test. This is to save memory on the AppVeyor build worker.
- Sometimes the integration tests failed to start services in the AppVeyor build worker. Now the value 'ServicesPipeTimeout' is set to the max of two minutes (default 30 seconds) in appveyor.yml (issue dsccommunity#1114).
johlju
changed the title
|
This will hopefully resolve all PR's being blocked by failing tests. I will merge this one as soon as it passes all checks. |
Codecov Report
@@ Coverage Diff @@
## dev #1115 +/- ##
=====================================
+ Coverage 97% 97% +<1%
=====================================
Files 32 32
Lines 3930 3936 +6
=====================================
+ Hits 3844 3850 +6
Misses 86 86 |
|
Reviewed 4 of 8 files at r1, 2 of 7 files at r2, 6 of 6 files at r3. Tests/Integration/MSFT_SqlServiceAccount.config.ps1, line 197 at r3 (raw file):
Should not have this comment Tests/Integration/MSFT_SqlServiceAccount.config.ps1, line 201 at r3 (raw file):
Remove extra blank row Comments from Reviewable |
|
Review status: 11 of 13 files reviewed at latest revision, 2 unresolved discussions. Tests/Integration/MSFT_SqlServiceAccount.config.ps1, line 197 at r3 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Tests/Integration/MSFT_SqlServiceAccount.config.ps1, line 201 at r3 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
|
Reviewed 1 of 8 files at r1, 1 of 1 files at r4. Comments from Reviewable |
Pull Request (PR) description
This is to save memory on the AppVeyor build worker.
the integration test. This is to save memory on the AppVeyor build worker.
Restart-ReportingServicesServiceshould no longer timeoutwhen restarting the service (issue #1114).
This is to save memory on the AppVeyor build worker.
This Pull Request (PR) fixes the following issues
Fixes #1114
Task list
should say what was changed, and how that affects users (if applicable).
and comment-based help?
See DSC Resource Testing Guidelines.
See DSC Resource Testing Guidelines.
DSC Resource Style Guidelines
and Best Practices?
This change is